-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for 2D cylindrical and 1D spherical #410
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #410 +/- ##
==========================================
+ Coverage 98.85% 98.86% +0.01%
==========================================
Files 49 49
Lines 1923 1943 +20
==========================================
+ Hits 1901 1921 +20
Misses 22 22
Continue to review full report at Codecov.
|
The failing patch coverage is due to a vsc bug which stagged the whole temperature_solver.py file as changed... |
Proposed changes
This PR adds the possibility to run simulations in cylindrical and spherical coordinates.
Usage:
Todo:
Types of changes
What types of changes does your code introduce to FESTIM?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...