(chocolateyGH-1121) API - Do not reset loggers

When providing a custom logger, do not reset other loggers.
ferventcoder · Jan 3, 2017 · 8d03724 · 8d03724
1 parent 3a1c58f
commit 8d03724
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/src/chocolatey/GetChocolatey.cs b/src/chocolatey/GetChocolatey.cs
@@ -106,7 +106,7 @@ public GetChocolatey()
         /// <returns>This <see cref="GetChocolatey"/> instance</returns>
         public GetChocolatey SetCustomLogging(ILog logger)
         {
-            Log.InitializeWith(logger);
+            Log.InitializeWith(logger, resetLoggers: false);
             return this;
         }
 

diff --git a/src/chocolatey/infrastructure/logging/Log.cs b/src/chocolatey/infrastructure/logging/Log.cs
@@ -31,22 +31,24 @@ public static class Log
         ///   Sets up logging to be with a certain type
         /// </summary>
         /// <typeparam name="T">The type of ILog for the application to use</typeparam>
-        public static void InitializeWith<T>() where T : ILog, new()
+        /// <param name="resetLoggers">Should other loggers be reset?</param>
+        public static void InitializeWith<T>(bool resetLoggers = true) where T : ILog, new()
         {
             _logType = typeof (T);
-            LogExtensions.ResetLoggers();
+            if (resetLoggers) LogExtensions.ResetLoggers();
         }
 
         /// <summary>
         ///   Sets up logging to be with a certain instance. The other method is preferred.
         /// </summary>
         /// <param name="loggerType">Type of the logger.</param>
+        /// <param name="resetLoggers">Should other loggers be reset?</param>
         /// <remarks>This is mostly geared towards testing</remarks>
-        public static void InitializeWith(ILog loggerType)
+        public static void InitializeWith(ILog loggerType, bool resetLoggers = true)
         {
             _logType = loggerType.GetType();
             _logger = loggerType;
-            LogExtensions.ResetLoggers();
+            if (resetLoggers) LogExtensions.ResetLoggers();
         }
 
         /// <summary>