Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OneInch Implementation With nonUpgradeable Contract #32

Conversation

SibghatUllah1997
Copy link
Contributor

Release Notes: Comprehensive Update to FiberRouter Contract

Enhancements:

  • 1inch Aggregator Router Address Setter

    • Implemented setOneInchAggregatorRouter in OneInchRouterSetter contract for updating the 1inch Aggregator Router address.
  • 1inch Data Decoder Addition

    • Added a OneInchDataDecoder to enhance data handling and parsing specific to 1inch transactions.
  • 1inch Helper Functions in FiberRouter

    • Integrated new helper functions in the FiberRouter contract for improved interaction with the 1inch protocol.

Refactoring and Security Improvements:

  • Refactoring Token Transfer Methods
    • Replaced all .transfer methods with sendToken for enhanced security and gas efficiency.
    • Transitioned from transferFrom to a more secure method provided by the SafeAmount library.

Events:

  • Event Logging for Router Address Updates
    • Added OneInchAggregatorRouterUpdated event for logging updates to the 1inch Router address.

Developer Notes:

  • Testing and Verification

    • Thorough testing of the new features and refactored code is crucial before deploying to the mainnet.
    • Pay special attention to the integration points with the 1inch protocol and the new token transfer methods.
  • Security Practices

    • Ensure adherence to security best practices, especially in the handling of token transfers and data decoding.
    • Review and implement robust access control for functions modifying critical contract parameters.

@zikriya zikriya merged commit 02d8bed into ferrumnet:feature/NonUpgradeable Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants