Fix ambiguous associated type usage on top of 0.20.1 #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 25, 2021
richardkiss
added a commit
to richardkiss/clvm_rs
that referenced
this pull request
Feb 25, 2021
Had to be careful with `funty`. See, for example ferrilab/bitvec#110
richardkiss
added a commit
to Chia-Network/clvm_rs
that referenced
this pull request
Feb 26, 2021
Had to be careful with `funty`. See, for example ferrilab/bitvec#110
This was referenced Mar 2, 2021
|
Superseded but thank you and my apologies. Did the patch release resolve this? |
|
the patch release fix the funty version to 1.1, if some other create requires funty 1.2 then it would be great to be able to support 1.2 as well. But as far as I'm concerned we have no such usecase, so it is fine to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
funty 1.2 adds an associated const which conflicts with
BitMemory::BITSon type inference.This PR resolve the ambiguity by expliciting trait to use.
This is meant to be based on 0.20.1 (which is not in the tree, I downloaded from crates.io)
Also could we release a 0.20.2 with this patch ?