Hercules P32: use Function.prototype.bind for QJSEngine

The old hacks for preserving the "this" object for engine.makeConnection, engine.connectControl, and engine.beginTimer do not work with QJSEngine, but QJSEngine brings support for ES5, which supports Function.prototype.bind. https://bugs.launchpad.net/mixxx/+bug/1733666
ferranpujolcamins · Nov 22, 2018 · b6cc848 · b6cc848
1 parent 94022aa
commit b6cc848
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/res/controllers/Hercules-P32-scripts.js b/res/controllers/Hercules-P32-scripts.js
@@ -141,7 +141,7 @@ P32.slipButton = new components.Button({
     connect: function () {
         for (var d = 1; d <= 4; d++) {
             this.connections.push(
-                engine.connectControl('[Channel' + d + ']', 'slip_enabled', this.output)
+                engine.connectControl('[Channel' + d + ']', 'slip_enabled', this.output.bind(this))
             );
         }
     },
@@ -222,9 +222,9 @@ P32.Deck = function (deckNumbers, channel) {
             };
         },
         connect: function () {
-            this.connections[0] = engine.connectControl(this.group, 'beatloop_size', this.output);
+            this.connections[0] = engine.connectControl(this.group, 'beatloop_size', this.output.bind(this));
             if (loopEnabledDot) {
-                this.connections[1] = engine.connectControl(this.group, 'loop_enabled', this.output);
+                this.connections[1] = engine.connectControl(this.group, 'loop_enabled', this.output.bind(this));
             }
         },
         output: function (value, group, control) {