Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added File Parameter #56

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

JayCroghan
Copy link

Added a --file parameter to all commands to allow for specifying a hosts file location. Sometimes I want to edit a different file than the system one, especially when dealing with docker.

console.log(chalk.yellow('Opening file: ' + file))
hostile.setFile(file);
}

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks for existence of param independent of command.

@@ -30,6 +37,8 @@ function help () {
remove [domain] Remove a domain from the hosts file
load [file] Load a set of host entries from a file
unload [file] Remove a set of host entries from a file

optional --file parameter to all commands to allow for manipulating other hosts files in non standard locations
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just adding to the help prompt.

{
exports.HOSTS = filePath
}

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the app runs per instance this should be reset every time it's run unless I'm missing something.

Copy link
Author

@JayCroghan JayCroghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant