Remove rimraf #27
Merged
Remove rimraf #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `recursive` option for `fs.rmdir` was added in Node.js 12.10.0. This sets `maxRetries` to 3, because that was the default value used by rimraf.
|
Released as 4.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the spirit of shedding dependencies, I've removed
rimrafwith therecursiveoption offs.rmdirwhich was added in Node.js 12.10 and which is now the active LTS. I'm opening this PR in case you're interested in merging this now or later when v10 reaches EOL next year.Just to be safe, this sets
maxRetriesto 3 in the user-facing code, because that was the default value used by rimraf.Thanks for cross-zip!