Improved feature-detection of chrome.sockets

[lidel]

What?

This PR adds explicit check if chrome.sockets.tcp and chrome.sockets.tcpServer exist before registering related listeners.

Why?

chrome-net did not check if used chrome.sockets.* APIs actually exist, which caused problems in browser extensions. Extension was unable to maintain the single codebase and do feature-detection at runtime (eg. Google Chrome without chrome.sockets vs Brave with).

This PR makes it possible to include chrome-net in generic build pipeline.

Refs. ipfs/ipfs-companion#664 ipfs/ipfs-companion#716

[jscissr]

Otherwise LGTM.

[lidel]

@jscissr any chance to publish a new release to npm with this? :)

[jscissr]

The problem is that @feross has enabled branch protection with required pull request review for master, and I can't approve my own changes. At the same time his status is:

Not checking GitHub notifications. Email me for urgent issues.

I could publish to npm, but then I can't push the version update commit to GitHub.

Some options I see are:

• Email @feross and ask him to disable required review or add another collaborator (but I'm not sure if you can call this urgent)
• If you @lidel open the PR instead of me, I could approve and merge it.

What do you think?

[lidel]

@jscissr I can help and open a PR, just let me know what should be in it :)

Version bump to 3.3.2 ? Anything else?

chrome-net/package.json

Line 4 in 1362648

"version": "3.3.1",

[jscissr]

You should be able to open a PR here: https://github.com/feross/chrome-net/compare/version-update?expand=1

[feross]

Sorry that I missed this message. Were you able to get this issue figured out and a new version published to npm?

[lidel]

Yes, its all good: it shipped in v3.3.2

[lidel]

I created a PR with the same fix for UDP API: feross/chrome-dgram#16