reduce environment variable provider precedence #2886
Merged
+6
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- inverts precedence of variables providers giving the environment variable provider least precedence Signed-off-by: Kate Goldenring <[email protected]>
fibonacci1729
approved these changes
Oct 14, 2024
lann
approved these changes
Oct 14, 2024
|
I agree that I would like @itowlson's thoughts before merging. I understand that env vars seem like they should take precedence on the CLI but seem less relevant when orchestrating Spin apps with SpinKube. Maybe we should make this configurable by the runtime when it loads the variables factor. |
|
Yes, I still have concerns, but by my count the majority of people feel this is the right thing to do. And my concern is for a specific scenario (the override on the command line one) that, at a technical level, is impossible to differentiate from other scenarios where I do agree this is the right thing to do. So I am keeping mousy quiet. What? By my standards, 60 words is mousy quiet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inverts precedence of variables providers giving the environment variable provider least precedence
fixes #2584