Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print active channels on redis trigger #2232

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

karthik2804
Copy link
Contributor

This PR prints active channels once the Redis trigger starts to improve the Ux slightly. In cases where the wasm modules take a while to prepare, it can look like Spin has hanged if there is no feedback to the user until they decide to send the first request and if it does not have any print statements, it will continue looking like that.

(e.g.)

$ spin up                                                                                                                  
Logging component stdio to ".spin/logs/"
Preparing Wasm modules is taking a few seconds...

after the pr it looks like

$ spin up
Logging component stdio to "examples/redis-rust/.spin/logs/"
Active Channels on redis://localhost:6379:
        messages: echo-message

Copy link
Collaborator

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! This will help in testing to know when the Redis trigger has started. We currently just wait a bit of time and hope that's good enough.

@karthik2804 karthik2804 merged commit 98b7e2e into fermyon:main Jan 19, 2024
11 checks passed
@karthik2804 karthik2804 deleted the redis_print_channels branch January 19, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants