update to Wasmtime 17 and WASI 0.2.0-rc-2023-12-05 #2222
Conversation
As of this writing, Wasmtime 17 has not yet been released, so we're temporarily pointing at the `release-17.0.0` branch. By the time it is released, WASI 0.2.0-rc-2023-12-05 will become WASI 0.2.0, at which point we'll need to update the WIT files and code to match. The upshot is that we'll be supporting three snapshots indefinitely: 2023-10-18, 2023-11-10, and 2023-12-05 AKA the final 0.2.0 release. Most of the changes here deal with supporting those three snapshots, while the rest deal with the Hyper 1.0 update, which led to a bit of awkwardness when mixing Hyper and Reqwest, since the latter has not yet been updated to use Hyper 1.0. Signed-off-by: Joel Dice <[email protected]>
Signed-off-by: Joel Dice <[email protected]>
|
I haven't been able to repro the CI test failures yet -- will keep investigating. |
|
Wasn't able to repro the CI failures on Mac or Linux. Look like they're hitting a 20 second timeout waiting for |
|
I just ran the same tests on |
|
@dicej sigh - I ran into the same issue... I think unfortunately the right move is probably to increase the time out. We could run with a release build, but then we have to pay the price of building that release artificat which is way more time than any reasonable timeout. I believe the timeout is currently at 20 seconds. I say we raise it to 2 minutes. If we hit the timeout still then we might want to think about how to make our debug builds faster. One additional idea I have is to run the built artifacts through wasm-tools strip. Smaller wasm binaries tend to load much faster. I'd like to be able to do that without requiring the user has wasm-tools on their path though. |
We're not sure yet why we've started consistently exceeding the old 20 second timeout on tests which run in a 2-3 seconds locally, but that's what's happening. If it turns out even 2 minutes is insufficient, we'll need to dig deeper. Signed-off-by: Joel Dice <[email protected]>
As of this writing, Wasmtime 17 has not yet been released, so we're temporarily pointing at the
release-17.0.0branch. By the time it is released, WASI 0.2.0-rc-2023-12-05 will become WASI 0.2.0, at which point we'll need to update the WIT files and code to match.The upshot is that we'll be supporting three snapshots indefinitely: 2023-10-18, 2023-11-10, and 2023-12-05 AKA the final 0.2.0 release.
Most of the changes here deal with supporting those three snapshots, while the rest deal with the Hyper 1.0 update, which led to a bit of awkwardness when mixing Hyper and Reqwest, since the latter has not yet been updated to use Hyper 1.0.