fix statically linked build issue for aarch #2179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajatjindal
force-pushed
the
reenable-static-spin
branch
from
141b0d4
to
8b63266
Compare
rajatjindal
changed the title
vdice
reviewed
Dec 15, 2023
Signed-off-by: Rajat Jindal <[email protected]>
Signed-off-by: Rajat Jindal <[email protected]>
rajatjindal
force-pushed
the
reenable-static-spin
branch
from
4037555
to
6fd630d
Compare
vdice
approved these changes
Dec 18, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aarch cross image was using old version of Ubuntu. I had to switch to using image marked as 'edge' in cross-rs repo to fix this.
a new version of cross has not been released in a long time, but using a sha256 of image should be safe until we have a better alternative.