Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRACEPARENT formatting in v1.4 preventing environment variables from being passed to lens #473

Closed
LTrestka opened this issue Aug 31, 2023 · 1 comment · Fixed by #479
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@LTrestka
Copy link

jobsub_lite is not formatting the "TRACEPARENT" environment variable correctly according to condor docs, this causes lens to fail at parsing.

All variables passed into the submission make it to the jobsub logs, and to kibana, but nothing in the list that comes after and including TRACEPARENT can be queried in lens.

ex:
Environment = "POMS4_CAMPAIGN_STAGE_NAME=dd_sample_campaign_stage_1 GRID_USER=ltrestka TRACEPARENT=\"00-e3131325f54a321cdb504f049bfcac76-3976795c459dbf45-01\" IFDH_DEBUG=1 EXPERIMENT=hypot POMS4_CAMPAIGN_STAGE_ID=2602 CLUSTER=71832400 [email protected] POMS4_CAMPAIGN_NAME=dd_sample_campaign_1 "

  • In this example , only POMS4_CAMPAIGN_STAGE_NAME and GRID_USER would make it to lens.
  • Note: I removed some variables to keep it simple, full submission can be seen here

Per the doc:

Put double quote marks around the entire argument string. This distinguishes the new syntax from the old. The old syntax does not have double quote marks around it. Any literal double quote marks within the string must be escaped by repeating the double quote mark.
https://htcondor.readthedocs.io/en/latest/man-pages/condor_submit.html (ctrl-f "enviroment")

@shreyb shreyb added the bug Something isn't working label Aug 31, 2023
@shreyb shreyb added this to the 1.4.1 milestone Aug 31, 2023
@retzkek
Copy link
Contributor

retzkek commented Aug 31, 2023

From what I can tell it's condor that's formatting the environment incorrectly - we actually specify it in the submit script with the "old" format. https://github.com/fermitools/jobsub_lite/blob/master/templates/simple/simple.cmd#L18

@marcmengel marcmengel self-assigned this Sep 28, 2023
marcmengel added a commit that referenced this issue Sep 28, 2023
@marcmengel marcmengel mentioned this issue Sep 28, 2023
@marcmengel marcmengel linked a pull request Sep 28, 2023 that will close this issue
@shreyb shreyb modified the milestones: 1.4.1, 1.5 Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants