fix: StartParameters on Windows #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugodutka
changed the title
|
@fergusstrange let me know what you think. |
embedded_postgres.go
Outdated
| @@ -200,9 +200,14 @@ func (ep *EmbeddedPostgres) Stop() error { | |||
|
|
|||
| func encodeOptions(port uint32, parameters map[string]string) string { | |||
| options := []string{fmt.Sprintf("-p %d", port)} | |||
| stringDelimitingChar := "'" | |||
| // CMD on Windows uses double quotes to delimit strings. It treats single quotes as regular characters. | |||
| if runtime.GOOS == "windows" { | |||
There was a problem hiding this comment.
Why not just move to usign " on all platforms? If you try it do tests still all pass?
There was a problem hiding this comment.
I originally wanted to keep the existing behavior identical on unaffected platforms, but looks like the tests all pass when using ".
There was a problem hiding this comment.
Yeah, I reckon this is a better overall improvement though, nice job!
fergusstrange
approved these changes
Dec 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #145.
Changes: