-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch npm to pnpm #714
Switch npm to pnpm #714
Conversation
electron-builder.npmrc tweaks This file contains tweaks required to run electron-builder with pnpm mentioned here electron-userland/electron-builder#6289 (comment) Issues after adding tweaks
Core issue Tests to be done
|
Moving back to draft :) As it is again blocked |
Added yet another small tweak to get around the blocker. |
9045efe
to
a82917f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't able to build this PR locally because it was throwing some errors related with MSVS Tools (I tested 2022, 2019 and 2017 with no success - it doesn't fail for my arch x64, but fails for the others).
Nevertheless, as the CI didn't fail for Windows, I vote for we to move to merge this PR.
Thank you @balajiv113 for not giving up on this conversion 😄
Tested to build on my windows 10 x64 and the builds for all architecture work exactly as expected! Well done @balajiv113 for that work 🤩 🎉 |
Co-authored-by: Markus Hatvan <[email protected]> Co-authored-by: Nathanaël Houn <[email protected]> Vijay Aravamudhan <[email protected]> Co-authored-by: André Oliveira <[email protected]>
Pre-flight Checklist
Description of Change
Move electron-builder outside of package.json script. As using inside is causing trouble in native buildings. The same model we already followed to fix windows building with pnpm
Checklist
pnpm prepare-code
)pnpm test
passesTesting
I have done testing on macOS
Steps to test
--$TARGET_ARCH --$TARGET_OS --dir
from the build scripts