Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add Crowdin languages mapping in config file #284

Merged
merged 3 commits into from
Aug 21, 2022
Merged

fix: add Crowdin languages mapping in config file #284

merged 3 commits into from
Aug 21, 2022

Conversation

andrii-bodnar
Copy link
Contributor

Hey everyone,

just noticed there are some language codes in the project that have locale code instead of two letters code. Crowdin has a feature to map these codes.

Also, I've noticed that there a some duplicated languages in the locales folder - zh and zh-Hans, zh-Hant and zh-TW. I guess some of these languages are excessive here but not sure which. @nathanaelhoun could you please point out what codes are unneeded here? I will remove them also and will update the mapping if needed

#185

@vraravam
Copy link
Contributor

@nathanaelhoun - would you be able to verify and approve this change? IF so, we can then merge it in?

@nathanaelhoun
Copy link
Contributor

Hi @andrii-bodnar, thanks for taking a look, and sorry for the delay in my response!

Your comment about duplicated languages is correct. Some of them as excessive, but unfortunately, I do not know chinese well and I couldn't tell which one are duplicates. Do you know?

Copy link
Contributor

@nathanaelhoun nathanaelhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, these changes are looking good to me!

@andrii-bodnar
Copy link
Contributor Author

@nathanaelhoun the same, also not sure which of these files are excessive 😬

@nathanaelhoun
Copy link
Contributor

I'll just merge this one after the checks pass, and we will clear up the maybe excessive languages in another PR. Thanks @andrii-bodnar!

@nathanaelhoun nathanaelhoun changed the title Fix: Crowdin languages mapping fix: add Crowdin languages mapping in config file Aug 21, 2022
@nathanaelhoun nathanaelhoun changed the base branch from develop to l10n_develop August 21, 2022 17:59
@nathanaelhoun nathanaelhoun merged commit e8b8cb4 into ferdium:l10n_develop Aug 21, 2022
nathanaelhoun added a commit that referenced this pull request Aug 21, 2022
Fix: Crowdin languages mapping

Co-authored-by: Nathanaël Houn <[email protected]>
nathanaelhoun added a commit that referenced this pull request Aug 22, 2022
* New translations en-US.json (Persian)

* New translations en-US.json (Croatian)

* New translations en-US.json (Hindi)

* New translations en-US.json (Flemish)

* New translations en-US.json (Bosnian)

* New translations en-US.json (Portuguese)

* New translations en-US.json (Norwegian)

* New translations en-US.json (French)

* New translations en-US.json (German)

* New translations en-US.json (Spanish)

* New translations en-US.json (Afrikaans)

* New translations en-US.json (Arabic)

* New translations en-US.json (Belarusian)

* New translations en-US.json (Catalan)

* New translations en-US.json (Czech)

* New translations en-US.json (Danish)

* New translations en-US.json (Greek)

* New translations en-US.json (Dutch)

* New translations en-US.json (Finnish)

* New translations en-US.json (Irish)

* New translations en-US.json (Hebrew)

* New translations en-US.json (Hungarian)

* New translations en-US.json (Italian)

* New translations en-US.json (Japanese)

* New translations en-US.json (Georgian)

* New translations en-US.json (Korean)

* New translations en-US.json (Sinhala)

* New translations en-US.json (Romanian)

* New translations en-US.json (Chinese Traditional)

* New translations en-US.json (Russian)

* New translations en-US.json (Slovak)

* New translations en-US.json (Serbian (Cyrillic))

* New translations en-US.json (Swedish)

* New translations en-US.json (Turkish)

* New translations en-US.json (Ukrainian)

* New translations en-US.json (Chinese Simplified)

* New translations en-US.json (Vietnamese)

* New translations en-US.json (Polish)

* New translations en-US.json (Portuguese, Brazilian)

* New translations en-US.json (Indonesian)

* New translations en-US.json (Persian)

* New translations en-US.json (Croatian)

* New translations en-US.json (Hindi)

* New translations en-US.json (Flemish)

* New translations en-US.json (Bosnian)

* New translations en-US.json (Portuguese)

* New translations en-US.json (Norwegian)

* New translations en-US.json (French)

* New translations en-US.json (German)

* New translations en-US.json (Spanish)

* New translations en-US.json (Afrikaans)

* New translations en-US.json (Arabic)

* New translations en-US.json (Belarusian)

* New translations en-US.json (Catalan)

* New translations en-US.json (Czech)

* New translations en-US.json (Danish)

* New translations en-US.json (Greek)

* New translations en-US.json (Dutch)

* New translations en-US.json (Finnish)

* New translations en-US.json (Irish)

* New translations en-US.json (Hebrew)

* New translations en-US.json (Hungarian)

* New translations en-US.json (Italian)

* New translations en-US.json (Japanese)

* New translations en-US.json (Georgian)

* New translations en-US.json (Korean)

* New translations en-US.json (Sinhala)

* New translations en-US.json (German)

* New translations en-US.json (Romanian)

* New translations en-US.json (Chinese Traditional)

* New translations en-US.json (Russian)

* New translations en-US.json (Slovak)

* New translations en-US.json (Serbian (Cyrillic))

* New translations en-US.json (Swedish)

* New translations en-US.json (Turkish)

* New translations en-US.json (Ukrainian)

* New translations en-US.json (Chinese Simplified)

* New translations en-US.json (Vietnamese)

* New translations en-US.json (Polish)

* New translations en-US.json (Portuguese, Brazilian)

* New translations en-US.json (Indonesian)

* New translations en-US.json (Persian)

* New translations en-US.json (Croatian)

* New translations en-US.json (Hindi)

* New translations en-US.json (Flemish)

* New translations en-US.json (Bosnian)

* New translations en-US.json (Portuguese)

* New translations en-US.json (Norwegian)

* New translations en-US.json (French)

* New translations en-US.json (German)

* New translations en-US.json (Spanish)

* New translations en-US.json (Afrikaans)

* New translations en-US.json (Arabic)

* New translations en-US.json (Belarusian)

* New translations en-US.json (Catalan)

* New translations en-US.json (Czech)

* New translations en-US.json (Danish)

* New translations en-US.json (Greek)

* New translations en-US.json (Dutch)

* New translations en-US.json (Finnish)

* New translations en-US.json (Irish)

* New translations en-US.json (Hebrew)

* New translations en-US.json (Hungarian)

* New translations en-US.json (Italian)

* New translations en-US.json (Japanese)

* New translations en-US.json (Georgian)

* New translations en-US.json (Korean)

* New translations en-US.json (Sinhala)

* New translations en-US.json (Romanian)

* New translations en-US.json (Chinese Traditional)

* New translations en-US.json (Russian)

* New translations en-US.json (Slovak)

* New translations en-US.json (Serbian (Cyrillic))

* New translations en-US.json (Swedish)

* New translations en-US.json (Turkish)

* New translations en-US.json (Ukrainian)

* New translations en-US.json (Chinese Simplified)

* New translations en-US.json (Vietnamese)

* New translations en-US.json (Polish)

* New translations en-US.json (Portuguese, Brazilian)

* New translations en-US.json (Indonesian)

* New translations en-US.json (Persian)

* New translations en-US.json (Croatian)

* New translations en-US.json (Hindi)

* New translations en-US.json (Flemish)

* New translations en-US.json (Bosnian)

* New translations en-US.json (Portuguese)

* New translations en-US.json (Norwegian)

* New translations en-US.json (French)

* New translations en-US.json (German)

* New translations en-US.json (Spanish)

* New translations en-US.json (Afrikaans)

* New translations en-US.json (Arabic)

* New translations en-US.json (Belarusian)

* New translations en-US.json (Catalan)

* New translations en-US.json (Czech)

* New translations en-US.json (Danish)

* New translations en-US.json (Greek)

* New translations en-US.json (Dutch)

* New translations en-US.json (Finnish)

* New translations en-US.json (Irish)

* New translations en-US.json (Hebrew)

* New translations en-US.json (Hungarian)

* New translations en-US.json (Italian)

* New translations en-US.json (Japanese)

* New translations en-US.json (Georgian)

* New translations en-US.json (Korean)

* New translations en-US.json (Sinhala)

* New translations en-US.json (Japanese)

* New translations en-US.json (Dutch)

* New translations en-US.json (German)

* New translations en-US.json (Dutch)

* New translations en-US.json (Dutch)

* New translations en-US.json (Dutch)

* New translations en-US.json (Italian)

* New translations en-US.json (Italian)

* New translations en-US.json (Portuguese, Brazilian)

* New translations en-US.json (Portuguese, Brazilian)

* New translations en-US.json (Romanian)

* New translations en-US.json (Chinese Traditional)

* New translations en-US.json (Russian)

* New translations en-US.json (Slovak)

* New translations en-US.json (Serbian (Cyrillic))

* New translations en-US.json (Swedish)

* New translations en-US.json (Turkish)

* New translations en-US.json (Ukrainian)

* New translations en-US.json (Chinese Simplified)

* New translations en-US.json (Vietnamese)

* New translations en-US.json (Polish)

* New translations en-US.json (Portuguese, Brazilian)

* New translations en-US.json (Indonesian)

* New translations en-US.json (Persian)

* New translations en-US.json (Croatian)

* New translations en-US.json (Hindi)

* New translations en-US.json (Flemish)

* New translations en-US.json (Bosnian)

* New translations en-US.json (Portuguese)

* New translations en-US.json (Norwegian)

* New translations en-US.json (French)

* New translations en-US.json (German)

* New translations en-US.json (Spanish)

* New translations en-US.json (Afrikaans)

* New translations en-US.json (Arabic)

* New translations en-US.json (Belarusian)

* New translations en-US.json (Catalan)

* New translations en-US.json (Czech)

* New translations en-US.json (Danish)

* New translations en-US.json (Greek)

* New translations en-US.json (Dutch)

* New translations en-US.json (Finnish)

* New translations en-US.json (Irish)

* New translations en-US.json (Hebrew)

* New translations en-US.json (Hungarian)

* New translations en-US.json (Italian)

* New translations en-US.json (Japanese)

* New translations en-US.json (Georgian)

* New translations en-US.json (Korean)

* New translations en-US.json (Sinhala)

* New translations en-US.json (Dutch)

* New translations en-US.json (Dutch)

* New translations en-US.json (Spanish)

* chore: removed typoed pr-BR.json translation file

* i18n: skip unstranslated strings in crowdin export

* New translations en-US.json (Romanian)

* New translations en-US.json (Chinese Traditional)

* New translations en-US.json (Russian)

* New translations en-US.json (Slovak)

* New translations en-US.json (Serbian (Cyrillic))

* New translations en-US.json (Swedish)

* New translations en-US.json (Turkish)

* New translations en-US.json (Ukrainian)

* New translations en-US.json (Chinese Simplified)

* New translations en-US.json (Vietnamese)

* New translations en-US.json (Polish)

* New translations en-US.json (Portuguese, Brazilian)

* New translations en-US.json (Indonesian)

* New translations en-US.json (Persian)

* New translations en-US.json (Croatian)

* New translations en-US.json (Hindi)

* New translations en-US.json (Flemish)

* New translations en-US.json (Bosnian)

* New translations en-US.json (Portuguese)

* New translations en-US.json (Norwegian)

* New translations en-US.json (French)

* New translations en-US.json (German)

* New translations en-US.json (Spanish)

* New translations en-US.json (Afrikaans)

* New translations en-US.json (Arabic)

* New translations en-US.json (Belarusian)

* New translations en-US.json (Catalan)

* New translations en-US.json (Czech)

* New translations en-US.json (Danish)

* New translations en-US.json (Greek)

* New translations en-US.json (Finnish)

* New translations en-US.json (Irish)

* New translations en-US.json (Hebrew)

* New translations en-US.json (Hungarian)

* New translations en-US.json (Italian)

* New translations en-US.json (Japanese)

* New translations en-US.json (Georgian)

* New translations en-US.json (Korean)

* New translations en-US.json (Sinhala)

* New translations en-US.json (Flemish)

* New translations en-US.json (Czech)

* i18n: add automatically_fill_regional_dialects in crowdin.yml

* fix: existing locales in crowdin (#562)

* fix: existing locales in crowdin

* fix(i18n): back to Nederlands for nl

Co-authored-by: Nathanaël Houn <[email protected]>

* fix: add Crowdin languages mapping in config file (#284)

Fix: Crowdin languages mapping

Co-authored-by: Nathanaël Houn <[email protected]>

* feat(i18n): customize PR title and commits

* Pulled down update to recipes submodule

* New translations en-US.json (French)

Co-authored-by: Nathanaël Houn <[email protected]>
Co-authored-by: André Oliveira <[email protected]>
Co-authored-by: Andrii Bodnar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants