Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This fixes my issues. #948

Closed
wants to merge 1 commit into from
Closed

This fixes my issues. #948

wants to merge 1 commit into from

Conversation

Megalodon-sharky
Copy link

No description provided.

@skick1234
Copy link
Contributor

skick1234 commented Jun 24, 2021

#946 is the correct way to fix the problem. Not just copy a workaround on the internet and make a pull request.

@D3SOX
Copy link
Contributor

D3SOX commented Jun 24, 2021

Yes, this is a duplicate of #946. Can probably be closed, the branch doesn't even exist anymore.

@TimeForANinja
Copy link
Collaborator

@Megalodon-sharky thanks for the PR
can you pls check if #946 does the job for you?

@Megalodon-sharky
Copy link
Author

@Megalodon-sharky thanks for the PR
can you pls check if #946 does the job for you?

Well, I use heroku, and I also use distube. If I do install this, it will install in node_modules. Where I really need it installed is in /node_modules/distube/node_modules. I'm really not sure how to do that on heroku and make it work but yea. I tested it on my PC where I made the changes manually and it worked. Still sad about how to fix the heroku thing

@konsumer
Copy link

Yeh, this just overrides what findJSON does (skipping it's params completely.)

If you want the fix in your heroku app, in node_modules, a better temporary solution (until it is merged & published in this library, on npm) would be to use @D3SOX PR, directly:

npm i git://github.com/D3SOX/node-ytdl-core#fix-info-endpoint-404

@redbrain redbrain mentioned this pull request Jun 25, 2021
@Megalodon-sharky
Copy link
Author

Yeh, this just overrides what findJSON does (skipping it's params completely.)

If you want the fix in your heroku app, in node_modules, a better temporary solution (until it is merged & published in this library, on npm) would be to use @D3SOX PR, directly:

npm i git://github.com/D3SOX/node-ytdl-core#fix-info-endpoint-404

But I don't know how to specify the path in heroku because inside node_modules, there is distube, the package I use and under distube there is another node_modules that contains ytdl-core.

@konsumer
Copy link

@MadLittleMods this will add it to your package.json, which tells heroku what to install in node_modules. Because the parent project has it as a dep, it should use that instead of the version marked in distube. Try it. It should work. I'd have to see your project layout to really troubleshoot, but that is how it's meant to work. Or alternately, you could wait for it to be merged.

@TimeForANinja
Copy link
Collaborator

closing since #946 was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants