Update getWatchHTMLPage right pos

[mome0320]

in WatchHTMLPage
info.response isn't end \n (it's last line)
so update right pos </script> is better.

In test I think it works.

[RisedSky]

This fix the issue using ytdl-core for Discord music bot
see #946 (review)

[TimeForANinja]

🤔 can't replicate
can you provide me with a watchHTMLPage you receive?
a simple fs.writeFileSync befor the line you edited should do it

[RisedSky]

This doesn't fix, getting the following error after playing the song :

stack: 'Error: aborted\n at connResetException (node:internal/errors:683:14)\n at TLSSocket.socketCloseListener (node:_http_client:407:19)\n at TLSSocket.emit (node:events:406:35)\n at node:net:661:12\n at TCP.done (node:_tls_wrap:580:7)\n at TCP.callbackTrampoline (node:internal/async_hooks:130:17)'

[mome0320]

can't replicate
can you provide me with a watchHTMLPage you receive?
a simple fs.writeFileSync befor the line you edited should do it

https://gist.github.com/mome0320/5ef235f47239a2dcb90f35baa79daa3c
here this file.

[mome0320]

This doesn't fix, getting the following error after playing the song :

stack: 'Error: aborted\n at connResetException (node:internal/errors:683:14)\n at TLSSocket.socketCloseListener (node:_http_client:407:19)\n at TLSSocket.emit (node:events:406:35)\n at node:net:661:12\n at TCP.done (node:_tls_wrap:580:7)\n at TCP.callbackTrampoline (node:internal/async_hooks:130:17)'

this PR may not affect about this error.

[TimeForANinja]

any reason for not moving all three findJSON to '</script>' ?
besides that this pr looks fine - already thanks for the time 😉

[mome0320]

any reason for not moving all three findJSON to '</script>' ?
besides that this pr looks fine - already thanks for the time

in 318 line?

  try {
    info.player_response = findJSON('watch.html', 'player_response',
      body, /\bytInitialPlayerResponse\s*=\s*\{/i, '\n', '{'); // this?
  } // ...

It works even if you don't change this line
but move all end '</script>' is fine for me.

[TimeForANinja]

yep, exactly that code

but move all end '</script>' is fine for me.

let's do it then
don't wanna touch this code again in the next months 😂

[TimeForANinja]

nice - tests are passing
gonna wait for #938 to be ready to merge before merging this...
will only confuse ppl when we bring half an update now...

[github-actions]

🎉 This PR is included in version 4.8.3 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[TimeForANinja]

Thanks again for the PR @mome0320 and everyone else who helped
For further Problems with (especially) video details check out #958