Skip to content
This repository has been archived by the owner on Oct 26, 2023. It is now read-only.

Update German translation #158

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Update German translation #158

wants to merge 3 commits into from

Conversation

Jeinzi
Copy link

@Jeinzi Jeinzi commented May 17, 2021

Hello! :)

I added the missing German translations, fixed two minor mistakes and reordered the lines to match the English translation file.
I hope this can be merged :)

@alex1701c
Copy link

Looks good from scrolling through the diff.

@fennifith Any thoughts on this MR?

Copy link

@Miepee Miepee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the MR i only have one comment.
Regarding the translation as a whole tho, I'd personally use Wecker instead of Alarm, as "Alarm" has a slightly different meaning and isn't usually associated with clocks.

app/src/main/res/values-de/strings.xml Outdated Show resolved Hide resolved
@Miepee
Copy link

Miepee commented Feb 15, 2022

Don't quotes " need to be escaped in XML with "?
Altho I see them further down escaped with \".

@Jeinzi
Copy link
Author

Jeinzi commented Feb 15, 2022

This says escaping is not necessary, but the quotes did not show up in the app without it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants