adding fullscreenNavigationUI option; fix #482 #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cevaris
changed the title
Codecov Report
@@ Coverage Diff @@
## master #483 +/- ##
==========================================
- Coverage 75.93% 75.80% -0.13%
==========================================
Files 8 8
Lines 1421 1422 +1
==========================================
- Hits 1079 1078 -1
- Misses 342 344 +2
Continue to review full report at Codecov.
|
|
Please do not push any automatically generated files, such as any files in the |
|
Your idea is good, but your solution may be a bit one-sided. |
fengyuanchen
force-pushed
the
add-fullscreenNavigationUI-option
branch
2 times, most recently
from
dac1cd4
to
ae69808
Compare
fengyuanchen
force-pushed
the
add-fullscreenNavigationUI-option
branch
from
ae69808
to
8214a36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On devices with soft UI buttons (Android/Amazon Fire, etc), when in fullscreen mode, some browsers still renders the soft UI buttons at the bottom of the screen, taking away from the "fullscreen" experience.
This PR adds a new Viewer option
fullscreenNavigationUI, to modify that soft UI button display behavior per Mozilla web spec.Fixes issue #482.
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Before:
After:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information:
I realize the contributing guidelines ask for a reproducible example.
Although, this particular issues requires a particular device with soft UI buttons and is reproducible via master branch.
Hopefully, that explanation is sufficient and this PR will be allowed.
Thanks!