Skip to content
This repository has been archived by the owner on Aug 1, 2020. It is now read-only.

Minor Style Issue with images #95

Closed
domoniquecarter35 opened this issue Nov 12, 2014 · 4 comments
Closed

Minor Style Issue with images #95

domoniquecarter35 opened this issue Nov 12, 2014 · 4 comments

Comments

@domoniquecarter35
Copy link

Hey just a heads up. If you plan to use this script make sure you remove all styling on images in your css. It took me and a friend three days to figure that this small thing was the solution to why cropper wasn't working on our site.

@domoniquecarter35 domoniquecarter35 changed the title It should be stated this Script is Bootstrap Only Minor Style Issue with images Nov 12, 2014
@peterchibunna
Copy link

Hi @domoniquecarter35, I will suggest that you check what other reason is
responsible for the plugin not working with your project. I'm successfully
using it in an ionic based mobile app.
On Nov 12, 2014 3:11 PM, "domoniquecarter35" [email protected]
wrote:

Hey just a heads up. Me and another dev spent hours and hours on trying to
figure out why your plugin wouldn't work with our website. It was after a
grueling three days that we finally figured out that the problem was
foundation.

It should be stated clearly in your documentation that this script only
works for bootstrap. It would have saved me and my friend a lot of time. We
are going to proceed to try and get it to work with foundation because this
seems to be the best cropping script we could find.

Once again it should clearly say in your documentation that this script
only works with bootstrap.

Thanks.


Reply to this email directly or view it on GitHub
#95.

@fengyuanchen
Copy link
Owner

@domoniquecarter35 Be sure not to add max-* and min-* css rules with!important to the img element before you use this plugin. If not, the cropper will not work fine. For example:

img {
  max-width: 100% !important;
  min-height: 160px !important;
}

@raja
Copy link

raja commented Nov 28, 2014

@fengyuanchen Can I suggest you add max-width/min-width: none to the img element that is generated for preview.

@fengyuanchen
Copy link
Owner

@raja Good idea! Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants