lkp-exec/install: Return success if package already installed #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When build_install_benchmarks encounters a pacakge that is already installed, pack returns 0 and subsequently hits the [ -f $deb_pkg ] || return check. In this case, we want to return success and continue with the installation. However, since a return with no integer parameter will simply return the result of the last statement, this returns false. Modify the return to explicitly return 0. Signed-off-by: John Allen <[email protected]>
|
Looks fengguang's repo is a bit out of date |
Dchharlow4171717
approved these changes
Dec 14, 2024
Dchharlow4171717
approved these changes
Dec 14, 2024
Dchharlow4171717
approved these changes
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When build_install_benchmarks encounters a pacakge that is already installed,
pack returns 0 and subsequently hits the [ -f $deb_pkg ] || return check.
In this case, we want to return success and continue with the installation.
However, since a return with no integer parameter will simply return the
result of the last statement, this returns false. Modify the return to
explicitly return 0.
Signed-off-by: John Allen [email protected]