Checkbox Component #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vuonga1103
reviewed
Jan 9, 2025
Co-authored-by: ctrl-alt-delete007 <[email protected]>
21shield
commented
Jan 11, 2025
Comment on lines
+6
to
+11
| ${({ | ||
| theme: { | ||
| semantic: { | ||
| color: { content }, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
This is an example for deconstructing from the theme might look like
21shield
commented
Jan 11, 2025
There was a problem hiding this comment.
Created and imported an svg to be used when a user clicks on the box < should this stay here?>
21shield
commented
Jan 11, 2025
Comment on lines
+18
to
+19
| borderColor: theme.semantic.color.border.default, | ||
| borderRadius: theme.semantic.border.radius.small, |
There was a problem hiding this comment.
This may be a little harder to deconstruct since the similarities end at semantic, in my opinion but open to it
21shield
commented
Jan 11, 2025
Comment on lines
+30
to
+34
| '&:after': { | ||
| content: "''", | ||
| background: 'white', | ||
| '-webkit-mask': `url(${checkmark})`, | ||
| maskRepeat: 'no-repeat', |
There was a problem hiding this comment.
created a psuedo element to help showcase the checkmark
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
DOD
Preview