Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AOS-358 Bedre overstyringsmuligheter og testbarhet for EventLogger #273

Merged
merged 5 commits into from
Dec 6, 2023
Merged

AOS-358 Bedre overstyringsmuligheter og testbarhet for EventLogger #273

merged 5 commits into from
Dec 6, 2023

Conversation

FrodeBjerkholt
Copy link
Contributor

No description provided.

erkdahl
erkdahl requested changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@erkdahl erkdahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ser veldig bra ut Frode! Takk for grundig refaktorering :) Har noen spørsmål og kommentarer og forslag til små endringer.

.gitignore Outdated Show resolved Hide resolved
log-event/src/main/java/no/digdir/logging/event/DefaultEventLogger.java Outdated Show resolved Hide resolved
log-event/src/main/java/no/digdir/logging/event/DefaultEventLogger.java Outdated Show resolved Hide resolved
log-event/src/main/java/no/digdir/logging/event/DefaultEventLogger.java Outdated Show resolved Hide resolved
log-event/src/test/java/no/digdir/logging/event/DiscardAndLogOldestPolicyTest.java Outdated Show resolved Hide resolved
log-event/src/main/java/no/digdir/logging/event/EventLogger.java Outdated Show resolved Hide resolved
log-event/src/main/java/no/digdir/logging/event/EventLoggingConfig.java Show resolved Hide resolved
...ent-spring-boot-starter/src/main/java/no/digdir/logging/event/EventLoggingConfigFactory.java Outdated Show resolved Hide resolved
...ent-spring-boot-starter/src/main/java/no/digdir/logging/event/EventLoggingConfigFactory.java Show resolved Hide resolved
log-event/pom.xml Show resolved Hide resolved
erkdahl
erkdahl approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@erkdahl erkdahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erkdahl erkdahl merged commit a845aa0 into main Dec 6, 2023
2 checks passed
@erkdahl erkdahl deleted the work/AOS-358 branch December 6, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erkdahl erkdahl erkdahl approved these changes

@kons-jaf kons-jaf Awaiting requested review from kons-jaf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FrodeBjerkholt @erkdahl