pythongh-112451: Make C-extension datetime.timezone acceptable as a b…

…ase class.
felixxm · Nov 29, 2023 · c689f7c · c689f7c
1 parent f9e6ce0
commit c689f7c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/Lib/test/test_types.py b/Lib/test/test_types.py
@@ -640,6 +640,11 @@ def test_traceback_and_frame_types(self):
     def test_capsule_type(self):
         self.assertIsInstance(_datetime.datetime_CAPI, types.CapsuleType)
 
+    def test_timezone_base_type(self):
+        class MyTimezone(_datetime.timezone):
+            pass
+
+        self.assertIs(issubclass(MyTimezone, _datetime.timezone), True)
 
 class UnionTests(unittest.TestCase):
 

diff --git a/Modules/_datetimemodule.c b/Modules/_datetimemodule.c
@@ -4107,7 +4107,7 @@ static PyTypeObject PyDateTime_TimeZoneType = {
     0,                                /* tp_getattro */
     0,                                /* tp_setattro */
     0,                                /* tp_as_buffer */
-    Py_TPFLAGS_DEFAULT,               /* tp_flags */
+    Py_TPFLAGS_DEFAULT | Py_TPFLAGS_BASETYPE, /* tp_flags */
     timezone_doc,                     /* tp_doc */
     0,                                /* tp_traverse */
     0,                                /* tp_clear */