Skip to content
This repository has been archived by the owner on Jun 23, 2019. It is now read-only.

Face: Added support for LargePersonGroup operations #53

Merged
merged 1 commit into from
Mar 23, 2018

Conversation

shaibt
Copy link
Collaborator

@shaibt shaibt commented Mar 21, 2018

  • face:identify() updated to support LargePersonGroups (breaking change)
  • face:verify() updated to support LargePersonGroups (non-breaking)
  • face: Updated all list() methods to support start/top optional params
  • face: updated tests for all additions and changes
  • updated api docs with additions and changes

Notes:

  • Breaking change in identify() was made to keep it a single API method like the Face API itself.
  • Did not add support for LargeFaceLists...maybe someone wants to pitch in?
  • only Face API tests were run (all successful). Added test for identify() which was missing beforehand.

- face:identify() updated to support LargePersonGroups (breaking change)
- face:verify() updated to support LargePersonGroups (non-breaking)
- face: Updated all list() methods to support start/top optional params
- face: updated tests for all additions and changes
- updated api docs with additions and changes
@felixrieseberg
Copy link
Owner

Dang, solid change, thank you very much! This is such excellent work I'll invite you as a contributor to this repository.

@felixrieseberg felixrieseberg merged commit 0a354c4 into felixrieseberg:master Mar 23, 2018
@shaibt
Copy link
Collaborator Author

shaibt commented Mar 25, 2018

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants