Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for creating a Queue with options #11

Merged
merged 3 commits into from
Sep 11, 2019

Conversation

kody-abe
Copy link
Contributor

@kody-abe kody-abe commented Sep 7, 2019

Per the spec https://github.com/OptimalBits/bull/blob/master/REFERENCE.md#queue creating a Queue can support additional options. This adds support for that.

Per the spec https://github.com/OptimalBits/bull/blob/master/REFERENCE.md#queue creating a Queue can support additional options. This adds support for that.
index.js Show resolved Hide resolved
@vcapretz
Copy link
Contributor

vcapretz commented Sep 9, 2019

Thanks for the PR!
Would be nice the update on the README page, I'll merge after it!

@kody-abe
Copy link
Contributor Author

kody-abe commented Sep 9, 2019

@vcapretz Added, please let me know if you wanted something more specific or called out

README.md Outdated Show resolved Hide resolved
@vcapretz
Copy link
Contributor

vcapretz commented Sep 9, 2019

@kody-abe it's perfect for now! we will eventually have more docs and use cases!

thanks!

Co-Authored-By: Vitor Capretz <[email protected]>
Copy link
Contributor

@erikengervall erikengervall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erikengervall erikengervall merged commit ff9d803 into felixmosh:master Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants