Remove add function according to code review

Adept setter to be a two for one function
felixmosh · Oct 14, 2019 · d02aadc · d02aadc
1 parent c8a800b
commit d02aadc
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 11 deletions.
diff --git a/README.md b/README.md
@@ -40,9 +40,9 @@ const Queue = require('bull');
 const someQueue = new Queue();
 const someOtherQueue = new Queue();
 
-const { addQueue, setQueues } = require('bull-board')
+const { setQueues } = require('bull-board')
 
-addQueue(someQueue).addQueue(someOtherQueue)
+setQueues(someQueue)
 
 // OR
 

diff --git a/example.js b/example.js
@@ -1,4 +1,4 @@
-const { createQueues, addQueue, setQueues, UI } = require('./')
+const { createQueues, setQueues, UI } = require('./')
 const app = require('express')()
 
 const sleep = t => new Promise(resolve => setTimeout(resolve, t * 1000))
@@ -13,8 +13,9 @@ const redisOptions = {
 }
 
 const run = () => {
-  addQueue(/* Already defined (bull) queue */);
   setQueues([/* Already defined (bull) queues */]);
+  // Or a single bull queue
+  setQueues(/* Already defined bull queue */);
 
   const queues = createQueues(redisOptions)
 

diff --git a/index.js b/index.js
@@ -29,15 +29,16 @@ function UI() {
 
 module.exports = {
   UI: UI(),
-  setQueues: (queues) => {
-    queues.forEach((item) => {
-      this.addQueue(item.queue);
+  setQueues: (bullQueues) => {
+    if (!Array.isArray(bullQueues)) {
+      bullQueues = [bullQueues];
+    }
+
+    bullQueues.forEach((item) => {
+      queues[item.name] = item;
     })
-  },
-  addQueue: (queue) => {
-    queues[queue.name] = queue
 
-    return this;
+    return queues
   },
   createQueues: redis => {
     return {