fix: apply settings default tab on failed status as well.

feat: add default option as default tab selection
felixmosh · Jan 19, 2025 · 11cf428 · 11cf428
1 parent 7893a60
commit 11cf428
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 6 deletions.
diff --git a/packages/ui/src/components/SettingsModal/SettingsModal.tsx b/packages/ui/src/components/SettingsModal/SettingsModal.tsx
@@ -68,7 +68,7 @@ export const SettingsModal = ({ open, onClose }: SettingsModalProps) => {
       <SelectField
         label={t('SETTINGS.DEFAULT_JOB_TAB')}
         id="default-job-tab"
-        options={availableJobTabs.map((tab) => ({
+        options={['default'].concat(availableJobTabs).map((tab) => ({
           text: t(`JOB.TABS.${tab.toUpperCase()}`),
           value: tab,
         }))}

diff --git a/packages/ui/src/hooks/useDetailsTabs.tsx b/packages/ui/src/hooks/useDetailsTabs.tsx
@@ -27,11 +27,7 @@ export function useDetailsTabs(currentStatus: Status) {
   }, [currentStatus]);
 
   useEffect(() => {
-    if (!tabs.includes(defaultJobTab) || currentStatus === STATUSES.failed) {
-      setSelectedTab(tabs[0]);
-    } else {
-      setSelectedTab(defaultJobTab);
-    }
+    setSelectedTab(tabs.includes(defaultJobTab) ? defaultJobTab : tabs[0]);
   }, [defaultJobTab, tabs]);
 
   return {

diff --git a/packages/ui/src/static/locales/en-US/messages.json b/packages/ui/src/static/locales/en-US/messages.json
@@ -48,6 +48,7 @@
       }
     },
     "TABS": {
+      "DEFAULT": "Default",
       "DATA": "Data",
       "OPTIONS": "Options",
       "LOGS": "Logs",

diff --git a/packages/ui/src/static/locales/es-ES/messages.json b/packages/ui/src/static/locales/es-ES/messages.json
@@ -50,6 +50,7 @@
       }
     },
     "TABS": {
+      "DEFAULT": "Predeterminado",
       "DATA": "Datos",
       "OPTIONS": "Opciones",
       "LOGS": "Registros",

diff --git a/packages/ui/src/static/locales/fr-FR/messages.json b/packages/ui/src/static/locales/fr-FR/messages.json
@@ -50,6 +50,7 @@
       }
     },
     "TABS": {
+      "DEFAULT": "Par défaut",
       "DATA": "Données",
       "OPTIONS": "Options",
       "LOGS": "Journaux",

diff --git a/packages/ui/src/static/locales/pt-BR/messages.json b/packages/ui/src/static/locales/pt-BR/messages.json
@@ -50,6 +50,7 @@
       }
     },
     "TABS": {
+      "DEFAULT": "Padrão",
       "DATA": "Dados",
       "OPTIONS": "Opções",
       "LOGS": "Logs",

diff --git a/packages/ui/src/static/locales/zh-CN/messages.json b/packages/ui/src/static/locales/zh-CN/messages.json
@@ -47,6 +47,7 @@
       }
     },
     "TABS": {
+      "DEFAULT": "默认",
       "DATA": "数据",
       "OPTIONS": "选项",
       "LOGS": "日志",