Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hover #50

Merged
merged 5 commits into from
Oct 19, 2016
Merged

Hover #50

merged 5 commits into from
Oct 19, 2016

Conversation

felixfbecker
Copy link
Owner

@felixfbecker felixfbecker commented Oct 8, 2016

Closes #17

Current implementation parses the docblock and displays the summary.

image

image

image

ToDo

  • Properties (parse @var tag)
  • Parameters (parse @param tag)
  • Variables
  • Return the signature of the declaration as a php MarkedString in addition to the documentation

@codecov-io
Copy link

codecov-io commented Oct 8, 2016

Current coverage is 92.29% (diff: 90.81%)

Merging #50 into master will decrease coverage by 0.41%

@@             master        #50   diff @@
==========================================
  Files            26         30     +4   
  Lines           604        688    +84   
  Methods          84         94    +10   
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            560        635    +75   
- Misses           44         53     +9   
  Partials          0          0          
Diff Coverage File Path
••••••• 76% new src/NodeVisitor/DocBlockParser.php
•••••••• 87% src/PhpDocument.php
••••••••• 94% src/Server/TextDocument.php
•••••••••• 100% new src/Protocol/MarkedString.php
•••••••••• 100% src/Protocol/Range.php
•••••••••• 100% src/Protocol/Diagnostic.php
•••••••••• 100% src/LanguageServer.php
•••••••••• 100% src/Project.php
•••••••••• 100% src/Protocol/Hover.php

Powered by Codecov. Last update 2e03aa3...1106521

@felixfbecker felixfbecker force-pushed the hover branch 11 times, most recently from 196a394 to c48a8f3 Compare October 11, 2016 23:35
@felixfbecker felixfbecker force-pushed the hover branch 3 times, most recently from e10f474 to 9f475a0 Compare October 19, 2016 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants