-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support type hinting #352
Support type hinting #352
Conversation
When fine, I'll create tests. But I'm unsure wether the code is okay like this. |
Codecov Report
@@ Coverage Diff @@
## master #352 +/- ##
============================================
- Coverage 84.2% 83.38% -0.83%
- Complexity 815 834 +19
============================================
Files 59 59
Lines 1722 1751 +29
============================================
+ Hits 1450 1460 +10
- Misses 272 291 +19
Continue to review full report at Codecov.
|
@felixfbecker is this still working, would be great to have this merged? should solve issue #350 right? |
This is based on an old version of the langserver that used a different parser, see the merge conflicts. It's also missing some tests. |
Okay, ehm, I will watch out when I got more time and then refile the pull request. |
This pr does include the pr #374, because the pr was created with the master branch. So I would like that the "define-constants" pr will be merged first.