formatDocument

[felixfbecker]

It can use the PHPParser's pretty printer

[mniewrzal]

Method 'textDocument/formatting' needs as response TextEdit array. PHPParser's pretty printer returns always formatted string and simplest solution is to create one TextEdit to replace whole document. If you don't plan to implement it in near future I can try to do this :) or maybe you have different idea how utilize PHPParser.

[felixfbecker]

Yes, I think that is the easiest solution. We currently also sync all textdocuments with full content, it doesn't seem to have significant perf impact, but it reduces complexity. We can adjust the implementation later.

Using PHPParser is of course not required for this, we could look at other formatting tools for PHP. But we already have the AST, so it is easier to just use the formatter, and the pretty printer comes included.

I'm super short on free time atm so yeah I would be more than happy if you implement it :)

[mniewrzal]

I was looking for alternative but I didn't found anything actively developed/maintained. For now PHPParser's pretty printer is easy to use but is not customizable. I think it will be easy to replace it with different formatting library if something will came up in the future.

[felixfbecker]

We could customize it by subclassing it. Or doing a PR to support some options :)
But I would like to get basic features out as quick as possible, customization can be added later.