-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SymbolInformation ranges are not accurate #27
Labels
Comments
Need to remove the @kaloyan-raev would you like to get write access to the repo? I would be fine if you do simple fixes like this directly as long as bigger features are discussed and reviewed on a PR. |
Sure. Thanks! |
kaloyan-raev
added a commit
to kaloyan-raev/php-language-server
that referenced
this issue
Sep 14, 2016
PR #28 fixes the end position. The rest should be fixed directly in the PHP Parser. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It looks like the
end
position of the ranges is shifted one character left than desired.The
start
position for class members does not cover the access modifier.The problem is not visible in VS Code, because it highlights the entire lines covered by the range.
But it is clearly visible in Eclipse Che which highlight the exact range. See the animation below.
The text was updated successfully, but these errors were encountered: