Check tweet json for rouge newlines to handle multiple json objects

[lwward]

Adding a second check for newlines helps fix issue with multiple json objects trying to be parsed by json_decode

Fixes #1

[felixdorn]

Thanks for your contribution!

I'm not sure how did you manage to get multiple json objects because as soon as the stream contains one \r\n, it yields the result so please provide more detailed context.

[lwward]

Thanks for your contribution!

I'm not sure how did you manage to get multiple json objects because as soon as the stream contains one \r\n, it yields the result so please provide more detailed context.

I believe it's because you are reading two characters at a time so the \r\n don't alway get grouped together. Below are a couple of examples to try and explain my thinking...

This example works:
{" na me ": "f el ix "} \r\n {" na me ": "s am "}

This one doesn't:
{" na me ": "l uk e" }\r \n{ "n am e" :" jo hn "}

[felixdorn]

Yeah! That makes sense, good catch!

There's just one thing: your solution will (potentially) store n tweets with an non even length until there's one with an even length which could result in an enormous string and tweets not being delivered in real time which is a big no-no.

It'd be better if we just take the current character and the last character of the $tweets variable and check if the two combined are \r\n.

Thanks for contributing!

[lwward]

Ah yes, good point. That's a much better solution

[felixdorn]

Fixed by d8e80d6 with the implementation we discussed