-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on ZipFile and remove GC call from read #273
Closed
TimG1964
wants to merge
18
commits into
felipenoris:master
from
TimG1964:Remove-dependency-on-ZipFile-and-remove-gc-call-from-read
Closed
Remove dependency on ZipFile and remove GC call from read #273
TimG1964
wants to merge
18
commits into
felipenoris:master
from
TimG1964:Remove-dependency-on-ZipFile-and-remove-gc-call-from-read
Commits on Oct 3, 2024
-
To make this work, I had to set the `enable_cache` kwarg to `true` rather than false for `readdata()` and `readtable()`
Configuration menu - View commit details
-
Copy full SHA for 8063a8a - Browse repository at this point
Copy the full SHA 8063a8aView commit details -
Added tests for rm after readdata and readtable
These tests will fail with `enable_cache=false` for both `readdata()` and `readtable()` (as in the current master). This PR changes this kwarg for these functions to `true`.
Configuration menu - View commit details
-
Copy full SHA for 7ccb887 - Browse repository at this point
Copy the full SHA 7ccb887View commit details
Commits on Oct 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3dc95bc - Browse repository at this point
Copy the full SHA 3dc95bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for fc3f8b1 - Browse repository at this point
Copy the full SHA fc3f8b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 281d5c1 - Browse repository at this point
Copy the full SHA 281d5c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7343cab - Browse repository at this point
Copy the full SHA 7343cabView commit details -
Configuration menu - View commit details
-
Copy full SHA for e0979b3 - Browse repository at this point
Copy the full SHA e0979b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for b189ea1 - Browse repository at this point
Copy the full SHA b189ea1View commit details -
Configuration menu - View commit details
-
Copy full SHA for d59aa69 - Browse repository at this point
Copy the full SHA d59aa69View commit details -
Configuration menu - View commit details
-
Copy full SHA for 55b570b - Browse repository at this point
Copy the full SHA 55b570bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 14a30c6 - Browse repository at this point
Copy the full SHA 14a30c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for f54349a - Browse repository at this point
Copy the full SHA f54349aView commit details -
Configuration menu - View commit details
-
Copy full SHA for acc6efb - Browse repository at this point
Copy the full SHA acc6efbView commit details -
Configuration menu - View commit details
-
Copy full SHA for d81e672 - Browse repository at this point
Copy the full SHA d81e672View commit details
Commits on Oct 9, 2024
-
Simplify per suggestion from @nhz2
This should be faster because it avoids creating a String and there is a check of the uncompressed_size in https://github.com/JuliaIO/ZipArchives.jl/blob/f955785e237a0a8b3607cf651eaebc1eb1037b8c/src/reader.jl#L344 Co-authored-by: Nathan Zimmerberg <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b28cc98 - Browse repository at this point
Copy the full SHA b28cc98View commit details -
Following suggestion from @nhz2
zip_openentry can be used here to avoid decompressing the entire entry into memory. Also, the error on the line after this can be removed with this change. Co-authored-by: Nathan Zimmerberg <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ffdc969 - Browse repository at this point
Copy the full SHA ffdc969View commit details -
Following suggestion from @nhz2
This should be faster because it avoids allocating all of the entry names at once. Co-authored-by: Nathan Zimmerberg <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 37eb14f - Browse repository at this point
Copy the full SHA 37eb14fView commit details
Commits on Oct 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7600fd5 - Browse repository at this point
Copy the full SHA 7600fd5View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.