Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on ZipFile and remove GC call from read #273

Commits on Oct 3, 2024

  1. Remove the gc call in read.jl

    To make this work, I had to set the `enable_cache` kwarg to `true` rather than false for `readdata()` and `readtable()`
    TimG1964 authored Oct 3, 2024
    Configuration menu
    Copy the full SHA
    8063a8a View commit details
    Browse the repository at this point in the history
  2. Added tests for rm after readdata and readtable

    These tests will fail with `enable_cache=false` for both `readdata()` and `readtable()` (as in the current master).
    
    This PR changes this kwarg for these functions to `true`.
    TimG1964 authored Oct 3, 2024
    Configuration menu
    Copy the full SHA
    7ccb887 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. Configuration menu
    Copy the full SHA
    3dc95bc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fc3f8b1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    281d5c1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7343cab View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e0979b3 View commit details
    Browse the repository at this point in the history
  6. Update types.jl

    TimG1964 authored Oct 4, 2024
    Configuration menu
    Copy the full SHA
    b189ea1 View commit details
    Browse the repository at this point in the history
  7. Remove ZipFile

    TimG1964 authored Oct 4, 2024
    Configuration menu
    Copy the full SHA
    d59aa69 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    55b570b View commit details
    Browse the repository at this point in the history
  9. Remove ZipFile

    TimG1964 authored Oct 4, 2024
    Configuration menu
    Copy the full SHA
    14a30c6 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    f54349a View commit details
    Browse the repository at this point in the history
  11. Remove ZipFile

    TimG1964 authored Oct 4, 2024
    Configuration menu
    Copy the full SHA
    acc6efb View commit details
    Browse the repository at this point in the history
  12. Remove ZipFile

    TimG1964 authored Oct 4, 2024
    Configuration menu
    Copy the full SHA
    d81e672 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Simplify per suggestion from @nhz2

    This should be faster because it avoids creating a String and there is a check of the uncompressed_size in https://github.com/JuliaIO/ZipArchives.jl/blob/f955785e237a0a8b3607cf651eaebc1eb1037b8c/src/reader.jl#L344
    
    Co-authored-by: Nathan Zimmerberg <[email protected]>
    TimG1964 and nhz2 authored Oct 9, 2024
    Configuration menu
    Copy the full SHA
    b28cc98 View commit details
    Browse the repository at this point in the history
  2. Following suggestion from @nhz2

    zip_openentry can be used here to avoid decompressing the entire entry into memory.
    
    Also, the error on the line after this can be removed with this change.
    
    Co-authored-by: Nathan Zimmerberg <[email protected]>
    TimG1964 and nhz2 authored Oct 9, 2024
    Configuration menu
    Copy the full SHA
    ffdc969 View commit details
    Browse the repository at this point in the history
  3. Following suggestion from @nhz2

    This should be faster because it avoids allocating all of the entry names at once.
    
    Co-authored-by: Nathan Zimmerberg <[email protected]>
    TimG1964 and nhz2 authored Oct 9, 2024
    Configuration menu
    Copy the full SHA
    37eb14f View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Following suggestion by @nhz2

    TimG1964 authored Oct 11, 2024
    Configuration menu
    Copy the full SHA
    7600fd5 View commit details
    Browse the repository at this point in the history