Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lazy-fixture-pytest library for upgrade to pytest v8.0.0 #889

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Remove lazy-fixture-pytest library for upgrade to pytest v8.0.0 #889

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d458b47
Bump pytest from 7.4.4 to 8.0.0
dependabot[bot] Jan 29, 2024
cae5f68
Remove pytest-lazy-fixture dependency
felddy Jan 31, 2024
7fd216d
Refactor container test to use lazy fixture evaluation
felddy Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,8 @@ def package_vars(version_file):
"coveralls == 3.3.1",
"docker == 7.0.0",
"pre-commit == 3.6.0",
"pytest == 7.4.4",
"pytest == 8.0.0",
"pytest-cov == 4.1.0",
"pytest-lazy-fixture == 0.6.3",
]
},
)
7 changes: 5 additions & 2 deletions tests/container_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,13 @@

@pytest.mark.parametrize(
"container",
[pytest.lazy_fixture("main_container"), pytest.lazy_fixture("version_container")],
["main_container", "version_container"],
)
def test_container_running(container):
def test_container_running(container, request):
"""Test that the container has started."""
# Lazy fixture evaluation
container = request.getfixturevalue(container)

# Wait until the container is running or timeout.
for _ in range(10):
container.reload()
Expand Down
Loading