forked from facebook/create-react-app
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add JSX source transform for better warnings (facebook#716)
Fixes facebook#700. Read about it here: https://twitter.com/dan_abramov/status/779308833399332864.
- Loading branch information
Showing
2 changed files
with
38 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,18 +35,40 @@ module.exports = { | |
// Resolve the Babel runtime relative to the config. | ||
moduleName: path.dirname(require.resolve('babel-runtime/package')) | ||
}] | ||
], | ||
env: { | ||
production: { | ||
plugins: [ | ||
// Optimization: hoist JSX that never changes out of render() | ||
// Disabled because of issues: | ||
// * https://github.com/facebookincubator/create-react-app/issues/525 | ||
// * https://phabricator.babeljs.io/search/query/pCNlnC2xzwzx/ | ||
// * https://github.com/babel/babel/issues/4516 | ||
// TODO: Enable again when these issues are resolved. | ||
// require.resolve('babel-plugin-transform-react-constant-elements') | ||
] | ||
} | ||
} | ||
] | ||
}; | ||
|
||
// This is similar to how `env` works in Babel: | ||
// https://babeljs.io/docs/usage/babelrc/#env-option | ||
// We are not using `env` because it’s ignored in versions > [email protected]: | ||
// https://github.com/babel/babel/issues/4539 | ||
// https://github.com/facebookincubator/create-react-app/issues/720 | ||
// It’s also nice that we can enforce `NODE_ENV` being specified. | ||
var env = process.env.BABEL_ENV || process.env.NODE_ENV; | ||
if (env !== 'development' && env !== 'test' && env !== 'production') { | ||
throw new Error( | ||
'Using `babel-preset-react-app` requires that you specify `NODE_ENV` or '+ | ||
'`BABEL_ENV` environment variables. Valid values are "development", ' + | ||
'"test", and "production". Instead, received: ' + JSON.stringify(env) + '.' | ||
); | ||
} | ||
var plugins = module.exports.plugins; | ||
if (env === 'development' || env === 'test') { | ||
plugins.push.apply(plugins, [ | ||
// Adds component stack to warning messages | ||
require.resolve('babel-plugin-transform-react-jsx-source'), | ||
// Adds __self attribute to JSX which React will use for some warnings | ||
require.resolve('babel-plugin-transform-react-jsx-self') | ||
]); | ||
} | ||
if (env === 'production') { | ||
// Optimization: hoist JSX that never changes out of render() | ||
// Disabled because of issues: | ||
// * https://github.com/facebookincubator/create-react-app/issues/525 | ||
// * https://phabricator.babeljs.io/search/query/pCNlnC2xzwzx/ | ||
// * https://github.com/babel/babel/issues/4516 | ||
// TODO: Enable again when these issues are resolved. | ||
// plugins.push.apply(plugins, [ | ||
// require.resolve('babel-plugin-transform-react-constant-elements') | ||
// ]); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters