Skip to content

Commit

Permalink
Fix the e2e test (facebook#699)
Browse files Browse the repository at this point in the history
* Fix the e2e test

In the end-to-end test, we want to test all the latest packages from
the monorepo instead of the versions from npm.

To do this we will now:
* run `lerna bootstrap` in the repo root folder before packaging react-scripts
* bundle the deps like we do for releases, so the e2e test uses those packages

* Fix copy-pasted comment
  • Loading branch information
fson authored and feiqitian committed Oct 25, 2016
1 parent 1a9fd51 commit d97d462
Showing 1 changed file with 13 additions and 4 deletions.
17 changes: 13 additions & 4 deletions tasks/e2e.sh
Original file line number Diff line number Diff line change
Expand Up @@ -96,23 +96,32 @@ clean_path=`mktemp -d 2>/dev/null || mktemp -d -t 'clean_path'`
# Copy some of the react-scripts project files to the temporary folder.
# Exclude folders that definitely won’t be part of the package from processing.
# We will strip the dev-only code there, `npm pack`, and copy the package back.
cd $root_path/packages/react-scripts
cd $root_path
rsync -av --exclude='.git' --exclude=$clean_path\
--exclude='node_modules' --exclude='build'\
'./' $clean_path >/dev/null

# Open the clean folder
cd $clean_path
cd $clean_path/packages/react-scripts

# Now remove all the code relevant to development of Create React App.
files="$(find -L . -name "*.js" -type f)"
for file in $files; do
sed -i.bak '/\/\/ @remove-on-publish-begin/,/\/\/ @remove-on-publish-end/d' $file
rm $file.bak
done

# Install all our packages
cd $clean_path
$root_path/node_modules/.bin/lerna bootstrap

cd $clean_path/packages/react-scripts

# This modifies package.json to copy all dependencies to bundledDependencies
node ./node_modules/.bin/bundle-deps

# Finally, pack react-scripts
npm install
scripts_path=$clean_path/`npm pack`
scripts_path=$clean_path/packages/react-scripts/`npm pack`

# ******************************************************************************
# Now that we have packed them, create a clean app folder and install them.
Expand Down

0 comments on commit d97d462

Please sign in to comment.