[apollo-server-testing] add complete typing for ...rest args

fixes apollographql#2172
feinoujc · Apr 13, 2019 · 81b9aa9 · 81b9aa9
1 parent 57c0056
commit 81b9aa9
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/packages/apollo-server-testing/CHANGELOG.md b/packages/apollo-server-testing/CHANGELOG.md
@@ -2,4 +2,6 @@
 
 ### vNEXT
 
+* Add variables prop to Query and Mutation types. Fixes #2172
+
 * `apollo-server-testing`: Added createTestClient function
diff --git a/packages/apollo-server-testing/src/createTestClient.ts b/packages/apollo-server-testing/src/createTestClient.ts
@@ -1,6 +1,8 @@
 import { ApolloServerBase } from 'apollo-server-core';
 import { print, DocumentNode } from 'graphql';
 
+type Omit<T, K extends keyof T> = Pick<T, Exclude<keyof T, K>>;
+
 type StringOrAst = string | DocumentNode;
 
 // A query must not come with a mutation (and vice versa).
@@ -9,7 +11,12 @@ type Mutation = { mutation: StringOrAst; query?: undefined };
 
 export default (server: ApolloServerBase) => {
   const executeOperation = server.executeOperation.bind(server);
-  const test = ({ query, mutation, ...args }: Query | Mutation) => {
+  const test = ({
+    query,
+    mutation,
+    ...args
+  }: (Query | Mutation) &
+    Omit<Parameters<typeof server.executeOperation>[0], 'query'>) => {
     const operation = query || mutation;
 
     if (!operation || (query && mutation)) {