fix

feiniaofeiafei · Jan 3, 2025 · 69c3ea6 · 69c3ea6
1 parent e7b6a46
commit 69c3ea6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 19 deletions.
diff --git a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalRepeat.java b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalRepeat.java
@@ -24,7 +24,6 @@
 import org.apache.doris.nereids.trees.expressions.NamedExpression;
 import org.apache.doris.nereids.trees.expressions.Slot;
 import org.apache.doris.nereids.trees.expressions.VirtualSlotReference;
-import org.apache.doris.nereids.trees.expressions.literal.NullLiteral;
 import org.apache.doris.nereids.trees.plans.Plan;
 import org.apache.doris.nereids.trees.plans.PlanType;
 import org.apache.doris.nereids.trees.plans.algebra.Repeat;
@@ -35,12 +34,9 @@
 import com.google.common.base.Preconditions;
 import com.google.common.collect.ImmutableList;
 
-import java.util.HashMap;
 import java.util.List;
-import java.util.Map;
 import java.util.Objects;
 import java.util.Optional;
-import java.util.Set;
 
 /**
  * LogicalRepeat.
@@ -194,19 +190,8 @@ public void computeUnique(DataTrait.Builder builder) {
 
     @Override
     public void computeUniform(DataTrait.Builder builder) {
-        DataTrait dataTrait = child(0).getLogicalProperties().getTrait();
-        Set<Expression> common = getCommonGroupingSetExpressions();
-        Map<Slot, Optional<Expression>> slotUniformValue = dataTrait.getSlotUniformValueMap();
-        Map<Slot, Optional<Expression>> newSlotUniformValue = new HashMap<>();
-        for (Map.Entry<Slot, Optional<Expression>> entry : slotUniformValue.entrySet()) {
-            Optional<Expression> value = entry.getValue();
-            if (!value.isPresent() || value.get() instanceof NullLiteral || common.contains(value.get())) {
-                newSlotUniformValue.put(entry.getKey(), value);
-            } else {
-                newSlotUniformValue.put(entry.getKey(), Optional.empty());
-            }
-        }
-        builder.addUniformSlotValueMap(newSlotUniformValue);
+        // don't generate uniform slot
+        // TODO: this need be supported later
     }
 
     @Override

diff --git a/fe/fe-core/src/test/java/org/apache/doris/nereids/properties/DataTraitTest.java b/fe/fe-core/src/test/java/org/apache/doris/nereids/properties/DataTraitTest.java
@@ -242,8 +242,7 @@ void testAgg() {
                 .rewrite()
                 .getPlan();
         System.out.println(plan.getLogicalProperties().getTrait());
-        Assertions.assertTrue(plan.getLogicalProperties().getTrait().isUniform(plan.getOutput().get(0))
-                && !plan.getLogicalProperties().getTrait().isUniformAndNotNull(plan.getOutput().get(0)));
+        // Assertions.assertTrue(plan.getLogicalProperties().getTrait().isUniform(plan.getOutput().get(0)));
     }
 
     @Test