(fix) Fix preventDefault inside passive events

feimosi · Mar 31, 2020 · 65f6b6e · 65f6b6e
1 parent ca8c54d
commit 65f6b6e
Showing 1 changed file with 10 additions and 6 deletions.
diff --git a/src/baguetteBox.js b/src/baguetteBox.js
@@ -317,27 +317,31 @@
     }
 
     function bindEvents() {
-        var options = supports.passiveEvents ? { passive: true } : null;
+        var passiveEvent = supports.passiveEvents ? { passive: false } : null;
+        var nonPassiveEvent = supports.passiveEvents ? { passive: false } : null;
+
         bind(overlay, 'click', overlayClickHandler);
         bind(previousButton, 'click', previousButtonClickHandler);
         bind(nextButton, 'click', nextButtonClickHandler);
         bind(closeButton, 'click', closeButtonClickHandler);
         bind(slider, 'contextmenu', contextmenuHandler);
-        bind(overlay, 'touchstart', touchstartHandler, options);
-        bind(overlay, 'touchmove', touchmoveHandler, options);
+        bind(overlay, 'touchstart', touchstartHandler, nonPassiveEvent);
+        bind(overlay, 'touchmove', touchmoveHandler, passiveEvent);
         bind(overlay, 'touchend', touchendHandler);
         bind(document, 'focus', trapFocusInsideOverlay, true);
     }
 
     function unbindEvents() {
-        var options = supports.passiveEvents ? { passive: true } : null;
+        var passiveEvent = supports.passiveEvents ? { passive: false } : null;
+        var nonPassiveEvent = supports.passiveEvents ? { passive: false } : null;
+
         unbind(overlay, 'click', overlayClickHandler);
         unbind(previousButton, 'click', previousButtonClickHandler);
         unbind(nextButton, 'click', nextButtonClickHandler);
         unbind(closeButton, 'click', closeButtonClickHandler);
         unbind(slider, 'contextmenu', contextmenuHandler);
-        unbind(overlay, 'touchstart', touchstartHandler, options);
-        unbind(overlay, 'touchmove', touchmoveHandler, options);
+        unbind(overlay, 'touchstart', touchstartHandler, nonPassiveEvent);
+        unbind(overlay, 'touchmove', touchmoveHandler, passiveEvent);
         unbind(overlay, 'touchend', touchendHandler);
         unbind(document, 'focus', trapFocusInsideOverlay, true);
     }