-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolves 2191 and 2196: cleanup and python wrapper for forms and implement feelpp namespace package #2227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
prudhomm
commented
Mar 18, 2024
- Have you checked to ensure there aren't other open Pull Requests for the same change?
- Have you added an explanation of what your changes do and why you'd like us to include them?
- Have you written new tests for your changes?
- Have you successfully run the Feel++ testsuite with your changes locally?
- Have you written Doxygen comments in your contribution ?
- closes minor cleanup of forms #2191
- closes create namespace package for python feelpp #2196
…' into 2191-minor-cleanup-of-forms
Clean Code #1494 [ci skip]
@vincentchabannes the path is hardcoded, what do you suggest ?
Clean Code #1494 [ci skip]
Closed
prudhomm
changed the title
resolves 2191: minor cleanup of forms
resolves 2191 and 2196: cleanup and python wrapper for forms and implement feelpp namespace package
Mar 18, 2024
|
[ci skip]
…191-minor-cleanup-of-forms
…191-minor-cleanup-of-forms
skip feelpp skip testsuite skip toolboxes skip mor
minor cleanup of forms #2191 skip feelpp skip testsuite skip toolboxes skip mor
skip feelpp skip testsuite skip toolboxes skip mor
minor cleanup of forms #2191 skip feelpp skip testsuite skip toolboxes skip mor
vincentchabannes
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.