Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

263 move data contribution guide #264

Merged
merged 15 commits into from
Jul 16, 2024
Merged

Conversation

lberti
Copy link
Contributor

@lberti lberti commented Sep 4, 2023

  • move data contribution Guide with Girder from feelpp/toolbox to book.feelpp.org

  • use partials of the "Data manual" from book.feelpp.org to keep showing the Data contribution guide inside the "Toolbox contribution guide" manual and the "Data manual"

  • closes Move data contribution guide #263

@lberti lberti requested a review from prudhomm September 4, 2023 09:49
@lberti lberti self-assigned this Sep 4, 2023
@lberti lberti linked an issue Sep 4, 2023 that may be closed by this pull request
@netlify
Copy link

netlify bot commented Sep 4, 2023

Deploy Preview for book-feelpp-adoring-edison-f92f3c ready!

Name Link
🔨 Latest commit c63aae2
🔍 Latest deploy log https://app.netlify.com/sites/book-feelpp-adoring-edison-f92f3c/deploys/6696098f273cba0008c5a66b
😎 Deploy Preview https://deploy-preview-264--book-feelpp-adoring-edison-f92f3c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@prudhomm
Copy link
Member

prudhomm commented Sep 4, 2023

screenshot

it seems that the new girder partial does not appear on the Data manual. does it ? Perhaps in Data Storage.
Also there was a discussion to use feelpp RemoteData to use Girder rather than the Girder API itself directly

Browser metadata
Path:      /data/
Browser:   Chrome 115.0.0.0 on Mac OS 10.15.7
Viewport:  1728 x 904 @2x
Language:  en-US
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

@lberti
Copy link
Contributor Author

lberti commented Sep 5, 2023

@prudhomm I have made some modifications in the navigation bar in order to put the pages under Data storage/Girder, and added a section for feelpp_remotedata to the already available documentation including Girder API.

Locally I can see the modifications if I specify the branches to be downloaded in the site.yml file. Maybe you can't see the menu here because of some configuration issue with Netlify?

@lberti
Copy link
Contributor Author

lberti commented Sep 5, 2023

It also seems that on some push, buildkite jobs are triggered (which causes the red crosses to appear next to the commits)

@lberti
Copy link
Contributor Author

lberti commented Sep 12, 2023

@prudhomm I can see the modifications locally. I wonder if there is a problem with the specification of branches in site.yml for the Netlify preview, as for example here

or here

There seem to be an analogous problem with this other pull request in feelpp/toolbox that is not able to properly find the partials that come from this PR.

@prudhomm
Copy link
Member

I am looking into this, thanks

@prudhomm prudhomm merged commit b2b2c24 into develop Jul 16, 2024
5 of 6 checks passed
@prudhomm prudhomm deleted the 263-move-data-contribution-guide branch July 16, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move data contribution guide
2 participants