218-reduced-basis-module-document-fails-to-execute-in-jupyter #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
thomas-saigre
commented
Nov 7, 2022
•
thomas-saigre
commented
- reduced basis module document fails to execute in jupyter #218
- fix errors due to bad xref or include
prudhomm
requested changes
Nov 7, 2022
|
|
||
| [source, python] | ||
| ---- | ||
| config = feelpp.globalRepository("reducedbasis") |
There was a problem hiding this comment.
use localRepository("reducedbasis") for jupyter
| - `config_file` : path to the cfg file | ||
| - `dim` : the dimension of the case | ||
| - `order` : the order of discretization (`1` for stem:[\mathbb{P}_1], `2` for stem:[\mathbb{P}_2]) | ||
| - `time_dependant` : is the case stationnary or transient ? (for now always to `False`) |
| heatBox.init() | ||
| model = toolboxmor(dim=DIM, time_dependent=False) | ||
| model.setFunctionSpaces( Vh=heatBox.spaceTemperature()) | ||
| config_file = "thermal-fin.cfg" |
There was a problem hiding this comment.
this is not robust. Do you create the file ? or should it be available somewhere ?
|
|
||
| [source,python] | ||
| ---- | ||
| cfg = feelpp.readCfg(config_file) |
There was a problem hiding this comment.
what is this function readCfg ?
| ---- | ||
| cfg = feelpp.readCfg(config_file) | ||
| feelpp.Environment.setConfigFile(config_file) | ||
| ---- |
| output_names.append(n) | ||
|
|
||
| print(f"Outputs of the models are {output_names}") | ||
| ---- |
| ---- | ||
| modelParameters = heatBox.modelProperties().parameters() | ||
| default_parameter = modelParameters.toParameterValues() | ||
| ---- |
There was a problem hiding this comment.
should we expect something ?
print the parameter may be ?
| ---- | ||
|
|
||
|
|
||
| [source, python] |
There was a problem hiding this comment.
describe the next block with respect to the math (affine decomposition...)
| [slepc4py] number of (smaller) eigenvalues computed : 16 | ||
| [reducedbasis] Constant of coercivity : 0.9999999999999977 | ||
| [slepc4py] number of eigenvalues computed : 16 | ||
| [reducedbasis] Constant of continuity : 1.0000000000000018 |
There was a problem hiding this comment.
continuity and coercivity are the same ? does it mean that the parameter for use is the one for the scalar product ?
|
@thomas-saigre I have merged your changes as it fixes things. However could you add some more explanations ? |
|
@thomas-saigre I didn't delete the branch, you can still work in it |
thomas-saigre
added a commit
that referenced
this pull request
Nov 16, 2022
prudhomm
pushed a commit
that referenced
this pull request
Nov 16, 2022
* write doc about : - parameters - petsc vectors - petsc matrix Write documentation on python x feel++ modules #151 [ci skip] * add documentation about parameters see commit feelpp/feelpp@9512e77 [ci skip] * add documentation about ModelProperties in python #151 * add documentation about functions wrapped in feelpp/feelpp@84a845d * up doc about `feelpp.mor._mor.ParameterSpace.New` [ci skip] * update doc according to feelpp/feelpp@2f3b94a * write documentation about online / offline usage * add title to the page [ci skip] * write doc about last modifications * move modelproperties to right directory * add details for `generate_basis` (and fix table of content) * fix nav to display rbm [ci skip] * doc : complete documentation about `reducedbasis` : offline and online * Update reducedbasis_online.adoc * add more details about reducedbasis in python #219 #151 /cc @prudhomm * fixes of some typos and remove files in double close #151
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.