Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modernize cmake #1

Closed
prudhomm opened this issue Jul 6, 2023 · 0 comments · Fixed by #2
Closed

modernize cmake #1

prudhomm opened this issue Jul 6, 2023 · 0 comments · Fixed by #2
Assignees
@prudhomm
Labels
enhancement New feature or request

Comments

@prudhomm
Copy link
Member

prudhomm commented Jul 6, 2023 •
edited
Loading

The cmake configuration can be improved in various ways:

  • add install statements
  • simplify executable generation and maintenance
  • add packaging configuration
  • remove include_directory and replace with target_link_libraries that allows to pass the necessary flags automatically
  • add googletest as submodule
  • add CMake preset support for vscode

see eg here https://cliutils.gitlab.io/modern-cmake/ for modern cmake

now installation looks like

cmake --preset default
cmake --build --preset default
ctest --preset default
@prudhomm prudhomm self-assigned this Jul 6, 2023
@prudhomm prudhomm added the enhancement New feature or request label Jul 6, 2023
prudhomm added a commit that referenced this issue Jul 6, 2023
@prudhomm
modernize cmake #1
eafed29 
- add googletest as submodule
- add cmake preset support
- use modern cmake
@prudhomm prudhomm linked a pull request Jul 6, 2023 that will close this issue
modernize cmake feelpp/EigenRand#1 #2
Merged
@prudhomm prudhomm mentioned this issue Jul 6, 2023
Merged
prudhomm added a commit that referenced this issue Jul 8, 2023
@prudhomm
add cmake preset instruction
c41d8c1 
modernize cmake #1
prudhomm added a commit that referenced this issue Jul 8, 2023
@prudhomm
modernize cmake #1
23de6ba 
- enable testing at toplevel
- remove googletest clone from workflow( simplification)
- detect eigen3 locally

/cc @bab2min
prudhomm added a commit that referenced this issue Jul 8, 2023
@prudhomm
update #1
f5a999a 
try fix CI (detection of Eigen3)
prudhomm added a commit that referenced this issue Jul 8, 2023
@prudhomm
try fix ci
ae5859f 
#1
prudhomm added a commit that referenced this issue Jul 8, 2023
@prudhomm
fix ci, make sure checkout is with submodules enabled
4e5f29f 
modernize cmake #1
prudhomm added a commit that referenced this issue Jul 8, 2023
@prudhomm
use ctest to simplify command line and working-directory
11d54b0 
#1
prudhomm added a commit that referenced this issue Jul 8, 2023
@prudhomm
use continue-on-error to check all possible failures
1285ea5 
#1
prudhomm added a commit that referenced this issue Jul 8, 2023
@prudhomm
user cmake preset to simplify, add windows preset
97dface 
#1
prudhomm added a commit that referenced this issue Jul 8, 2023
@prudhomm
fix string in ci modernize cmake #1
e6e3434
prudhomm added a commit that referenced this issue Jul 8, 2023
@prudhomm
fix ci for windows
e0cfddd 
#1
prudhomm added a commit that referenced this issue Jul 8, 2023
@prudhomm
use -latest runners
5334851 
#1
prudhomm added a commit that referenced this issue Jul 8, 2023
@prudhomm
use Visual Studio 17 2022 for windows-latest
8aef276 
#1
prudhomm added a commit that referenced this issue Jul 8, 2023
@prudhomm
Merge pull request #2 from feelpp/1-modernize-cmake
ce3a8d4 
modernize cmake #1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prudhomm prudhomm

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

modernize cmake feelpp/EigenRand#1 feelpp/EigenRand
1 participant
@prudhomm