Make MQTT compile under Win32 + allow base64 to work w/o object #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I assume that we always want STATIC libs, as all other ones, even on Linux/macOS
|
Correct, marking it as shared was a mistake on my part. Thanks a lot for the change! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per commit message, this fixes MQTT not compiling under Win32 and I also turned base64 function into statics so that they can run without a crypto object which is needed for my cspot PR. I also modified opencore-aacdec's CMakefile to make it work under Win32. I made library static as I assumed (maybe wrongly) that we always want static, like all other codecs.