Add initial .travis.yml #15
Conversation
|
👍 Cool, that build looks good! |
|
@philbrookes Thanks. We can improve on the build process as needed |
|
|
||
| script: | ||
| - gofmt -d -s $(find . -name '*.go') | ||
| - test -z "$(gofmt -d -s $(find . -name '*.go'))" |
There was a problem hiding this comment.
Why do we run gofmt on the same input twice?
There was a problem hiding this comment.
The first run is to show the developer what the formatting problem is, if any.
The second run is to allow picking up on if there was any output and fail the build accordlingly, because go fmt always seems to exit with a 0.
|
@rhcarvalho For any suggestions you have on improving on this, you can create a jira in issues.jboss.org/browse/FH |
|
I'm first commenting here to get an understanding closer to the code. Moving this to a different tool just adds friction to the conversation. Once we know if there's anything that needs to change we can create tickets. Sounds good? |
|
@rhcarvalho Sounds good |
No description provided.