This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Update travis file and show build & dependency icons in README #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crosbie
commented
Jun 20, 2017
Crosbie
commented
- Now run npm test as part of Travis build
- Increase test timeout (from 2 to 5 sec) to avoid travis failing intermittently
- Show Build & Dependency status' on README
- Upgrade body-parser dependency to newer version (verified with tests)
| @@ -2,7 +2,7 @@ | |||
| "name": "helloworld-cloud", | |||
| "version": "0.2.0", | |||
| "dependencies": { | |||
| "body-parser": "~1.0.2", | |||
| "body-parser": "~1.17.2", | |||
There was a problem hiding this comment.
Updating body-parser to this version throws deprecate warnings when running grunt serve, so don't update it for now, or also update the code to avoid the deprecate warnings.
GMT body-parser deprecated bodyParser: use individual json/urlencoded middlewares at lib/hello.js:8:13
GMT body-parser deprecated undefined extended: provide extended option at node_modules/body-parser/index.js:105:29
There was a problem hiding this comment.
BTW, if you decide to do it later, I've created an Epic to track dependencies updates as most Cloud apps will need this too. Feel free to create an issue for helloworld-cloud and link it to the Epic
https://issues.jboss.org/browse/RHMAP-16281
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.