Allow init to delete daemorundir #2133
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a service specifies a runtime directory in its systemd service file with the `RuntimeDirectory=` property, systemd will take care of creating and deleting it. From the docs[1]: "In case of RuntimeDirectory= the innermost subdirectories are removed when the unit is stopped.". Allow init to delete such directories, otherwise the following definition is not enough: ``` type foo_var_run_t; files_base_file(foo_var_run_t) init_daemon_run_dir(foo_var_run_t, "foo") ``` Right now there are no issues because management permissions are granted to init via `files_pid_file(foo_var_run_t)` which is commonly used. [1] https://www.freedesktop.org/software/systemd/man/255/systemd.exec.html#RuntimeDirectory=
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a service specifies a runtime directory in its systemd service file with the
RuntimeDirectory=property, systemd will take care of creating and deleting it.From the docs[1]: "In case of RuntimeDirectory= the innermost subdirectories are removed when the unit is stopped.".
Allow init to delete such directories, otherwise the following definition is not enough:
Right now there are no issues because management permissions are granted to init via
files_pid_file(foo_var_run_t)which is commonly used.[1] https://www.freedesktop.org/software/systemd/man/255/systemd.exec.html#RuntimeDirectory=