Warn users that logging in with email addresses is not supported

Fixes: #1475

Signed-off-by: Aurélien Bompard <[email protected]>

news/1475.bug.md

@@ -0,0 +1 @@
+Warn users that logging in with email addresses is not supported

noggin/form/login_user.py

@@ -3,14 +3,15 @@
 from wtforms.validators import DataRequired, Optional
 
 from .base import ModestForm, SubmitButtonField
-from .validators import no_mixed_case
+from .validators import no_email, no_mixed_case
 
 
 class LoginUserForm(ModestForm):
     username = StringField(
         _('Username'),
         validators=[
             DataRequired(message=_('You must provide a user name')),
+            no_email,
             no_mixed_case,
         ],
     )

noggin/form/validators.py

@@ -74,3 +74,8 @@ def __call__(self, form, field):
         for pattern in patterns:
             if re.match(pattern, value):
                 raise ValidationError(self.message % {"pattern": pattern})
+
+
+def no_email(form, field):
+    if "@" in field.data:
+        raise ValidationError(_("Please use your username, not your email address."))

tests/unit/controller/test_authentication.py

@@ -224,6 +224,23 @@ def test_login_bad_format(client, mocker, username):
     assert maybe_ipa_login.call_args_list[0][0][2] == username
 
 
+def test_login_email_address(client):
+    """Test giving an email address instead of a username"""
+    result = client.post(
+        '/',
+        data={
+            "login-username": "[email protected]",
+            "login-password": "dummy_password",
+            "login-submit": "1",
+        },
+    )
+    assert_form_field_error(
+        result,
+        "login-username",
+        "Please use your username, not your email address.",
+    )
+
+
 @pytest.mark.vcr()
 def test_login_incorrect_password(client, dummy_user):
     """Test a incorrect password"""